Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[59920] Fixed group_by for single and multiselct hierarchy custom field #17491

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[59920] Fixed group_by for single and multiselct hierarchy custom field #17491

merged 3 commits into from
Dec 20, 2024

Conversation

apfohl
Copy link
Member

@apfohl apfohl commented Dec 18, 2024

Ticket

59920

Screenshots

Screenshot From 2024-12-18 13-15-35

@apfohl apfohl requested review from ulferts, a team and toy December 18, 2024 13:14
@apfohl apfohl force-pushed the bug/59920-impossible-to-group-by-cf-hierarchy-multi-select branch from e06b3c4 to e8b847d Compare December 19, 2024 10:01
Kharonus
Kharonus approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the boyscouting on the aggregation group.

good work on figuring out the SQL statements. Would be nice to see a review from ivan or jens, but as it is close to christmas I wouldn't force it.

mereghost
mereghost approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@mereghost mereghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biased review af, but nice work! <3

@apfohl apfohl merged commit 9595ce3 into dev Dec 20, 2024
11 checks passed
@apfohl apfohl deleted the bug/59920-impossible-to-group-by-cf-hierarchy-multi-select branch December 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kharonus Kharonus Kharonus approved these changes

@mereghost mereghost mereghost approved these changes

@ulferts ulferts Awaiting requested review from ulferts

@toy toy Awaiting requested review from toy

Assignees
No one assigned
Labels
needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apfohl @mereghost @Kharonus